-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more time for restart tests to reach yellow state. #48434
Merged
jakelandis
merged 1 commit into
elastic:master
from
jakelandis:increase_timeout_for_yellow
Oct 24, 2019
Merged
Allow more time for restart tests to reach yellow state. #48434
jakelandis
merged 1 commit into
elastic:master
from
jakelandis:increase_timeout_for_yellow
Oct 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testWatcher method will on occasion timeout waiting for a yellow cluster state. This change increases the timeout to 60s.
jakelandis
added
>test
Issues or PRs that are addressing/adding tests
:Data Management/Watcher
v8.0.0
v7.6.0
labels
Oct 23, 2019
Pinging @elastic/es-core-features (:Core/Features/Watcher) |
martijnvg
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 24, 2019
The testWatcher method will on occasion timeout waiting for a yellow cluster state. This change increases the timeout to 60s.
This was referenced Oct 24, 2019
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 24, 2019
The testWatcher method will on occasion timeout waiting for a yellow cluster state. This change increases the timeout to 60s.
jakelandis
added a commit
that referenced
this pull request
Oct 24, 2019
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 4, 2019
…r yellow The timeout was increased to 60s to allow this test more time to reach a yellow state. However, the test will still on occasion fail even with the 60s timeout. Related: elastic#48381 Related: elastic#48434 Related: elastic#47950 Related: elastic#40178
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 4, 2019
…tic#48848) The timeout was increased to 60s to allow this test more time to reach a yellow state. However, the test will still on occasion fail even with the 60s timeout. Related: elastic#48381 Related: elastic#48434 Related: elastic#47950 Related: elastic#40178
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 4, 2019
…tic#48848) The timeout was increased to 60s to allow this test more time to reach a yellow state. However, the test will still on occasion fail even with the 60s timeout. Related: elastic#48381 Related: elastic#48434 Related: elastic#47950 Related: elastic#40178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/Watcher
>test
Issues or PRs that are addressing/adding tests
v7.5.0
v7.6.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testWatcher method will on occasion timeout waiting for
a yellow cluster state. This change increases the timeout
to 60s.
As part of re-enabling via #47950 this test was run for 24+ hours without failure on a dedicated node. I believe that this timeout is an environmental issue and 60s should be plenty of time.